Handle base path by routeCollector instead of RouteCollectorProxy #2844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment, basePath is handled by both RouteCollectorProxy and RouteCollector.
This PR:
RouteCollector::$basePath
when creating routes via DispatcherRouteCollectorProxy::setBasePath
andRouteCollectorProxy::getBasePath
methods which now call RouteCollector methodsRouteCollectorProxy::$basePath
to$groupPattern
as that's what it isThere are no B/C changes.
Fixes #2842 and possibly #2512
For test case, see Slim-4-basepath-issue