php-di/php-di added in composer -> suggest #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to give proper hints where possible for the developer specially who are newbie. So they can get started with appropriate tools and library. For the documentation `http://www.slimframework.com/docs/v4/concepts/di.html`. Most of the people will start using implementing Container without installing any container library. So I guess, it would be great to show suggestions for the developer to install DI bridge to work with container.
shahariaazam
changed the title
l0gicgate
reviewed
Oct 23, 2019
composer.json
Outdated
| @@ -76,6 +76,6 @@ | |||
| "ext-simplexml": "Needed to support XML format in BodyParsingMiddleware", | |||
| "ext-xml": "Needed to support XML format in BodyParsingMiddleware", | |||
| "slim/psr7": "Slim PSR-7 implementation. See http://www.slimframework.com/docs/v4/start/installation.html for more information.", | |||
| "php-di/slim-bridge": "PHP-DI bridge library is essential to use container in Slim" | |||
| "php-di/php-di": "PHP-DI bridge library is needed to use container in Slim" | |||
There was a problem hiding this comment.
PHP-DI bridge library is needed to use container in Slim
PHP-DI is the recommended container library to be used with Slim
|
Please make the appropriate changes and resolve the conflicts and I will merge. Thanks |
l0gicgate
approved these changes
Nov 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.