Fix prophecies

[adriansuter]

Fixes #2901.

[coveralls]

Coverage remained the same at 100.0% when pulling f4617ae on adriansuter:patch-prophecies into 4b83e02 on slimphp:4.x.

[l0gicgate]

Should we update the composer file as well to 1.10?

https://github.com/slimphp/Slim/blob/4.x/composer.json#L52

[adriansuter]

Sure, I don't think anyone will get hurt.

[froschdesign]

@adriansuter @l0gicgate
First: great to see your quick reaction on this topic.
But so far it is not clear if it is a problem in Prophecy and / or a BC break. Maybe it would help if you joined the discussion to the related issue report. This could be helpful, also for others.

[adriansuter]

I just wrote to the corresponding issue phpspec/prophecy#458. Let's see and wait.

In the meantime, how about updating composer.json into

        "phpspec/prophecy": ">1.8 <1.10",

[l0gicgate]

"phpspec/prophecy": ">1.8 <1.10",

@adriansuter this is a good temporary solution.

Using Argument::is() is also a good solution but it makes me worried about all the changes we have to do to all the other repos.

Thank you for the quick PR by the way. I think we should probably wait to merge this until we hear back on phpspec/prophecy#457

[t0mmy742]

phpspec/prophecy#460 is going to resolve this issue.

But, as mentionned in the PR, it is a best practice to use Argument::is() for strict comparison.

It is maybe better for Slim to use Argument::is() (we don't have that much changes to do in other repos).

[l0gicgate]

Okay @t0mmy742 I'm going to merge this then.