Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename phpcs.xml to phpcs.xml.dist #2916

Merged
merged 3 commits into from Jan 6, 2020
Merged

Rename phpcs.xml to phpcs.xml.dist #2916

merged 3 commits into from Jan 6, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 354f2f9 on voyula:patch-1 into 207acac on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.5.0 milestone Jan 5, 2020
l0gicgate
l0gicgate requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add this filename to .gitattributes as well so it doesn't get exported during releases

@ghost
Copy link
Author

ghost commented Jan 6, 2020

We need to add this filename to .gitattributes as well so it doesn't get exported during releases

Already added?

@l0gicgate l0gicgate merged commit 33f2aea into slimphp:4.x Jan 6, 2020
@l0gicgate l0gicgate mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @l0gicgate