Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README file #3108

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Update README file #3108

merged 1 commit into from
Aug 23, 2021

Conversation

t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Aug 22, 2021 •
edited
Loading

Since we dropped PHP 7.2 and Guzzle PSR-7 packages does not requires http-interop/http-factory-guzzle anymore.

EDIT:
Tests PHP 7.2 from GitHub CI should be removed from expected tests since we removed it from our configuration.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d79af5 on t0mmy742:update_readme into b9b6339 on slimphp:4.x.

l0gicgate
l0gicgate approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution 👌🏼

@l0gicgate l0gicgate added this to the 4.9.0 milestone Aug 23, 2021
@l0gicgate l0gicgate merged commit 9b5a64c into slimphp:4.x Aug 23, 2021
@t0mmy742 t0mmy742 deleted the update_readme branch August 25, 2021 22:19
@l0gicgate l0gicgate mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t0mmy742 @coveralls @l0gicgate