--use-local-mounts=true will fail

[tsujie]

pkg/app/master/command/build/image.go

Fixes-###

What

When I run slim build with --use-local-mounts=true and provide local state-path. Then the slim build will fail with error

cmd=build info=build.error status='optimized.image.build.error' error='no layers' 

Why

The reason is for local mounts, there is no files.tar file exits. Only the files folder exists. But the check is

dataDir := filepath.Join(imageInspector.ArtifactLocation, "files")
if fsutil.Exists(dataTar) && fsutil.IsDir(dataDir) {
  layerInfo := imagebuilder.LayerDataInfo{
	  Type:   imagebuilder.DirSource,
	  Source: dataDir,
	  Params: &imagebuilder.DataParams{
		  TargetPath: "/",
	  },
  }
  
  opts.Layers = append(opts.Layers, layerInfo)
  hasData = true
} else {
  logger.Info("WARNING - no data artifacts")
}

which will check if dataTar exists. In this case, it is false, so it will trigger the failure

How Tested

set --use-local-mounts=true and provide your local --state-path

[kcq]

@tsujie thanks a lot for the enhancement! Do you mind signing it and adding it here

[tsujie]

sure

…

On Fri, Oct 4, 2024 at 2:36 PM Kyle Quest ***@***.***> wrote: @tsujie <https://github.com/tsujie> thanks a lot for the enhancement! Do you mind signing it and adding it here <https://github.com/mintoolkit/mint/pulls> — Reply to this email directly, view it on GitHub <#718 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3JQ7EFDSUBT76VHIIBPUTZZ4C4LAVCNFSM6AAAAABPMTJEV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUG4YDEMZQGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>