Port to new vulkano #3902
Merged
Port to new vulkano #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might fix the issue with resizing causing swapchain re-creation errors, because "Swapchain creation no longer returns an error when the swapchain extent doesn't match the current surface extent." cc #3850
tronical
force-pushed
the
simon/vulkano-update
branch
from
62dfbd7 to
0a6aba7
Compare
|
With this PR app no longer crashes, but still have strange artifacts(have them before) simplescreenrecorder-2023-11-11_10.26.09.mp4 |
|
Thanks for checking - much appreciated. Regarding the resize artifacts: I have an idea what might cause this. When the swap chain image is for example suboptimal or similar, we should not just return - we should also make sure that render is called again. I'll see about fixing that in a separate PR. |
ogoffart
approved these changes
Nov 11, 2023
tronical
added
the
candidate-for-bugfix-release
ogoffart
removed
the
candidate-for-bugfix-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix the issue with resizing causing swapchain re-creation errors, because "Swapchain creation no longer returns an error when the swapchain extent doesn't match the current surface extent."
cc #3850