This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Delta to MdAST #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahor
reviewed
Dec 15, 2017
index.js
Outdated
|
|
||
| function toMdAST() { | ||
| this.Parser = function(file) { | ||
| const result = fromDelta({})(JSON.parse(file)); |
There was a problem hiding this comment.
You can return directly the call to fromDelta here :)
src/fromDelta.js
Outdated
| while (currentNode.depth > 0) { | ||
| let parentNode = currentNode.parent(); | ||
| parentNode.children = insertListInChildren(parentNode.children); | ||
| currentNode = currentNode.parent(); |
There was a problem hiding this comment.
Can't you use parentNode here?
currentNode = parentNode
src/fromDelta.js
Outdated
| parentNode.children = insertListInChildren(parentNode.children); | ||
| currentNode = currentNode.parent(); | ||
| } | ||
| currentNode.parent().children = insertListInChildren( |
There was a problem hiding this comment.
Since we don't know what the method parent() does exactly, it would be better to affect its result to a var if we are going to use it more than once, for performance reasons.
antoineduban
force-pushed
the
feat/delta-to-md
branch
from
88bc63c to
0fedb0a
Compare
Shahor
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.