fix: handle non-primary-key, non-assoc fields #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloanelybutsurely
approved these changes
Oct 10, 2024
|
i don't think there's much risk here. thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #37, I believe this solves the problem for regular fields which are not keys. The proposed solution is to always store a
:prefixin the result ofvalidate_opts!, even when it'snil. So for assocsprefixis going to benil, and for regular fields it's going to store the actual vakue.Inside
find_prefix, we use the stored:prefixif it's notnil(in case of primary keys and non-key fields), otherwise, (assocs) we fetch the prefix in the associated module's schema.I'm just not sure it doesn't break any existing use.