Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.prototype.at for next-polyfill-module #1

Merged

Conversation

spiltbeans
Copy link

This PR builds on an existing pull request #44436 by @sloanesturz.

This PR address the concerns in the original PR where it was still necessary to add the polyfill to the next-polyfill-module.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@sloanesturz
Copy link
Owner

Hey @spiltbeans! I have completely lost track of this issue and the solution (I just deleted .at() from my codebase).

Do you mean to add a PR into next.js instead of my fork of it?

@spiltbeans
Copy link
Author

Hey @sloanesturz I was looking to fix the polyfill issue you were trying to solve. Your PR just got bumped yesterday so I think others in the community want a solution as well.

From what I understand, your solution hasn't been merged since it only adds code to the next-polyfill-nomodule. (see TkDodo's comment)

I didn't want to submit a duplicate PR into next.js so I thought if I added the missing piece to your branch then maybe your PR would be merged.

So yes, I intended to make a PR to your fork, which I was hoping would go into next.js

@spiltbeans
Copy link
Author

Hey @sloanesturz I just want to bump this PR. Do you plan on merging this PR and syncing your branch up with canary? Otherwise I'll open up a duplicate PR in the next.js repo.

Thanks 😄

@sloanesturz sloanesturz merged commit e17cea9 into sloanesturz:polyfill-at Aug 21, 2023
@spiltbeans spiltbeans deleted the next-polyfill-module-at branch September 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants