forked from kumahq/kuma
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci(github): move checklist to a PR (kumahq#11654)
This is so that we can use the PR description as a commit message. Also the checklist should be checked by the reviewer. xrel Kong/team-mesh#302 Signed-off-by: Charly Molter <charly.molter@konghq.com>
- Loading branch information
Showing
2 changed files
with
30 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,20 @@ | ||
### Checklist prior to review | ||
## Motivation | ||
|
||
<!-- | ||
Each of these sections need to be filled by the author when opening the PR. | ||
<!-- Why are we doing this change --> | ||
|
||
If something doesn't apply please check the box and add a justification after the `--` | ||
--> | ||
## Implementation information | ||
|
||
<!-- Explain how this was done and potentially alternatives considered and discarded --> | ||
|
||
- [ ] [Link to relevant issue][1] as well as docs and UI issues -- | ||
- [ ] This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like `syscall.Mkfifo` have equivalent implementation on the other OS -- | ||
- [ ] Tests (Unit test, E2E tests, manual test on universal and k8s) -- | ||
- Don't forget `ci/` labels to run additional/fewer tests | ||
- [ ] Do you need to update [`UPGRADE.md`](../blob/master/UPGRADE.md)? -- | ||
- [ ] Does it need to be backported according to the [backporting policy](../blob/master/CONTRIBUTING.md#backporting)? ([this](https://github.com/kumahq/kuma/actions/workflows/auto-backport.yaml) GH action will add "backport" label based on these [file globs](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L6), if you want to prevent it from adding the "backport" label use [no-backport-autolabel](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L8) label) -- | ||
## Supporting documentation | ||
|
||
<!-- Is there a MADR? An Issue? A related PR? --> | ||
|
||
Fix #XX | ||
|
||
<!-- | ||
> Changelog: skip | ||
--> | ||
<!-- | ||
Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? | ||
--> | ||
|
||
[1]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters