feat(gemini): ACP integration, agent architecture refactor, and UX improvements #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move AgentBackend, AgentRegistry to core/ - Create transport/ with TransportHandler abstraction - Move Gemini-specific logic to GeminiTransport - Create adapters/ for message transformation - Create factories/ for high-level agent creation - Rename AcpSdkBackend → AcpBackend - Remove acp/utils.ts (merged into transport handlers)
…proved UX ACP Integration: - Add sendAgentMessage() for unified Agent Communication Protocol format - Migrate all Gemini messages from sendCodexMessage to sendAgentMessage(gemini, ...) - Add ACP message types: task_started, task_complete, turn_aborted, permission-request Model Selection: - Support dynamic model selection from frontend via meta.model - Save selected model to ~/.gemini/config.json for persistence Permission Handling: - Integrate GeminiPermissionHandler with permission modes (default, read-only, safe-yolo, yolo) - Add permission ID to tool call ID mapping for proper UI tracking Message Flow Improvements: - Add waitForResponseComplete() to ensure all chunks received before task_complete - Accumulate response chunks and send complete message once (fixes fragmentation) - Fix status flickering by not resetting thinking on intermediate idle events Error Handling: - Add retry logic for empty response errors (up to 3 retries) - Improve quota error handling: no retry, show reset time, suggest alternative model - Better error messages for model not found, rate limits, quota exceeded Tool Handling: - Improve change_title detection from toolCallId pattern - Add tool-result emission after permission approval - Track hadToolCallInTurn for proper task_complete timing
- Add ConversationHistory class to track user/assistant messages - Inject previous conversation context into new session on model change - Allows seamless model switching without losing context
…ling - Add `happy gemini project set/get` commands for Workspace accounts - Store project ID per-account (linked to email) - Show helpful error message for "Authentication required" with guide link - Sync local ~/.gemini/oauth_creds.json on `happy connect gemini` - Add `happy connect status` command to show vendor auth status - Pass GOOGLE_CLOUD_PROJECT env var to Gemini SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major improvements to Gemini integration including ACP (Agent Communication Protocol) support, architectural refactoring of the agent module, and enhanced user experience features.
Changes
🏗️ Agent Module Architecture Refactor
AgentBackend,AgentRegistrytocore/transport/withTransportHandlerabstractionadapters/for message transformation (MessageAdapter,MobileMessageFormat)factories/for high-level agent creationAcpSdkBackend→AcpBackendGeminiTransporthandler for Gemini-specific logic🔌 ACP Integration for Gemini
sendAgentMessage()for unified Agent Communication Protocol formatsendCodexMessagetosendAgentMessage(gemini, ...)task_started,task_complete,turn_aborted,permission-request🔄 Model Selection & History
meta.model~/.gemini/config.jsonfor persistenceConversationHistoryclass to preserve context when switching models🔐 Permission Handling
GeminiPermissionHandlerwith permission modes (default, read-only, safe-yolo, yolo)🔐 Google Cloud Project Support
happy gemini project set/getcommands for Workspace/enterprise accountsGOOGLE_CLOUD_PROJECTenv var to Gemini SDK🛠️ Error Handling & Reliability
waitForResponseComplete()to ensure all chunks received beforetask_complete📱 UX Improvements
happy connect statuscommand to show vendor auth status~/.gemini/oauth_creds.jsononhappy connect gemini🐛 Bug Fixes