Skip to content

Fix #46: Stop logging notification tokens #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bra1nDump merged 3 commits into from
Nov 28, 2025
Merged

Fix #46: Stop logging notification tokens #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd1a597
Describe push token logging vulnerability
CodingCanuck Oct 14, 2025
0fba925
Stop logging push notification tokens
CodingCanuck Oct 14, 2025
e62bca9
Remove vulnerability document
CodingCanuck Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/api/pushNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export class PushNotificationClient {

logger.debug(`Fetched ${response.data.tokens.length} push tokens`)

// Log detailed token information (FULL TOKENS FOR TESTING)
// Log token information
response.data.tokens.forEach((token, index) => {
logger.debug(`[PUSH] Token ${index + 1}: id=${token.id}, token=${token.token}, created=${new Date(token.createdAt).toISOString()}, updated=${new Date(token.updatedAt).toISOString()}`)
logger.debug(`[PUSH] Token ${index + 1}: id=${token.id}, created=${new Date(token.createdAt).toISOString()}, updated=${new Date(token.updatedAt).toISOString()}`)
})

return response.data.tokens
Expand Down Expand Up @@ -138,9 +138,9 @@ export class PushNotificationClient {
const tokens = await this.fetchPushTokens()
logger.debug(`[PUSH] Fetched ${tokens.length} push tokens`)

// Log token details for debugging (FULL TOKENS FOR TESTING)
// Log token details for debugging
tokens.forEach((token, index) => {
logger.debug(`[PUSH] Using token ${index + 1}: id=${token.id}, token=${token.token}`)
logger.debug(`[PUSH] Using token ${index + 1}: id=${token.id}`)
})

if (tokens.length === 0) {
Expand All @@ -150,7 +150,7 @@ export class PushNotificationClient {

// Create messages for all tokens
const messages: ExpoPushMessage[] = tokens.map((token, index) => {
logger.debug(`[PUSH] Creating message ${index + 1} for token: ${token.token}`)
logger.debug(`[PUSH] Creating message ${index + 1} for token`)
return {
to: token.token,
title,
Expand All @@ -170,4 +170,4 @@ export class PushNotificationClient {
}
})()
}
}
}