Custom dict delimiter #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gregoiredx
force-pushed
the
custom-dict-delimiter
branch
from
73f58e1
to
74c8e4d
Compare
gregoiredx
force-pushed
the
custom-dict-delimiter
branch
from
74c8e4d
to
990c699
Compare
|
@sloria , WDYT about this? Does it makes sense to you? |
|
@sloria , a little up on this one. Can you merge this? Or should I close the PR? |
|
@sloria , it's been a year 😄 |
|
Sorry for the delay here. This looks good. I need to update CI to use github actions but haven't had the time. I'll go ahead and merge this but won't be able to release until CI is fixed. |
|
cool thanks |
|
this is now released in 10.0.0 |
|
Yeah 🎉 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the
delimiterfordictas it is already the case forlist.