-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keccak #65
Draft
mkannwischer
wants to merge
13
commits into
main
Choose a base branch
from
keccakneon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Keccak #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hanno-becker
force-pushed
the
keccakneon
branch
2 times, most recently
from
July 30, 2024 04:03
4ed2641
to
d5f8e45
Compare
Rebase on top of #81 |
hanno-becker
force-pushed
the
keccakneon
branch
from
September 16, 2024 05:26
a8b111c
to
63d138c
Compare
hanno-becker
force-pushed
the
keccakneon
branch
from
September 26, 2024 17:39
63d138c
to
e634e3d
Compare
hanno-becker
force-pushed
the
keccakneon
branch
from
September 29, 2024 18:56
02664c5
to
2106e63
Compare
When `split_heuristic_preprocess_naive_interleaving` is enabled, SLOTHY preprocesses the input by naively reordering instructions according to their depths in the computational flow graph. This commit introduces another naive interleaving strategy "alternate" which will make SLOTHY alternate evenly between instructions tagged with `interleaving_class=0/1`. This is useful when two sequential blocks of code are to be interleaved as evenly as possible, which is common in scalar/Neon hybrids.
hanno-becker
force-pushed
the
keccakneon
branch
from
October 1, 2024 19:22
fe3885a
to
85de739
Compare
hanno-becker
force-pushed
the
keccakneon
branch
from
October 2, 2024 05:13
85de739
to
d1ec964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP adding Keccak via SLOTHY.
Right now this is a hybrid 4x Keccak (2 scalar, 2 Neon). I de-interleaved the previous manual-interleaved code and optimized it via SLOTHY. There is still a lot of potential for refactoring.
In the current state (slothy-optimizer/pqax@c69030c), the results look as follow:
For reference:
The 6624 is already quite a bit faster than the 7288 reported in https://kannwischer.eu/papers/2022_armv8keccak.pdf
This is still slower than the 1x scalar one in the same paper which was 1418; 1418*4=5672)
Related to slothy-optimizer/pqax#6