EID and SVM login #475
Open
EID and SVM login #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al into eid-login
…al into eid-login
|
@alhafoudh tuto je extremne dolezite vyriesit aj scenar, ze sa odhlasujeme. Musi sa odhlasit aj na slovensko.sk @luciajanikova vie detaily. |
jsuchal
reviewed
Jun 24, 2022
lib/omniauth/strategies/eid.rb
Outdated
| def parse_eid_expires_at(token) | ||
| Time.zone.at(parse_eid_token(token)&.first&.fetch('exp')) | ||
| end | ||
|
|
||
| def parse_eid_token(token) | ||
| if Rails.env.development? | ||
| JWT.decode(token, nil, false) |
There was a problem hiding this comment.
Toto ale musime overit ci to je validne a vsetko, inak ti podhodim token s hocijakym sub, nepodpisany.
* master: (24 commits) bumped gemfile lock (#474) delete images from repo (#484) Check if this works Check if this works Update gh actions to push code to gitlab (#480) Freeze devcontainer ruby version and add missing js deps install (#472) ND-96 Upload obrázkov(súborov) na amazon (#468) #392 Generate automatic slug for Page, Journey, Step and App test precompile assets test precompile assets test precompile assets test precompile assets test precompile assets test precompile assets test precompile assets test precompile assets test precompile assets precompile assets edit migrate command precompile assets ... # Conflicts: # Gemfile # db/structure.sql
…ge (#588) Without this the rails/webdrivers installation into mcr.microsoft.com/vscode/devcontainers/base:bullseye fails with: make DESTDIR\= sitearchdir\=./.gem.20230627-76-qe4u9x sitelibdir\=./.gem.20230627-76-qe4u9x install make: /usr/bin/mkdir: No such file or directory Co-authored-by: Marek Ceľuch <celuchmarek@gmail.com>
* Fix voting subscription * Fix tests
* enable ziadost o volebny preukaz * update vote preukaz * use google spreadsheets api v4 getting municipality emails * minor style fix in vote app * show email template even when email is present and show municipality email address * update municipality form * update municipality form * update municipality form 3 * fix municipality form * use new spreadsheet for municipality emails
* replace n with rn and fix typo in email subject * fix tests * bump ruby and some gems to fix tests
* start tests * test progress * tests wip * add upvs submission spec * rm upvs_submissions factory * add datahub db to tests * fix upvs submission model spec * add test env value for sk api url to GH workflow
Bumps [puma](https://github.com/puma/puma) from 6.1.1 to 6.3.1. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v6.1.1...v6.3.1) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jano Suchal <jan.suchal@slovensko.digital>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jano Suchal <jan.suchal@slovensko.digital>
* use env variables for parliament vote app dates * fix syntax --------- Co-authored-by: Jano Suchal <jan.suchal@slovensko.digital>
…digital into update_seeds # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Add missing seeds & Update existing
…digital into update_seeds # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Update seeds
* Add tests for category detail --------- Co-authored-by: Jano Suchal <jan.suchal@slovensko.digital> Co-authored-by: Jan Suchal <jan.suchal@gmail.com>
* Improved healtcheck, which checks if the app is running and also if the connections to databases are established * Modified healthcheck test to include databases checks * health_spec test includes coverage for negative scenarios, modified the index of health_controller
* add is number validation to vote app * fix syntax * fix: go back button (#622) * added Go Back button to pages where missing * fix: test in spec/features/apps/parliament_vote_app_spec.rb * add ux tweaks and rewords based on ux recommendations * add president_vote_app * udpate date calculation in president vote app * change president election app email addresses sheet * disable birth number validation * use checkboxes instead of radios on place selection * update president app after testing * minor wording update * add minor text hint to place selection * revert unwanted changes * rm email client button from auth person send * add tests and refactor a bit * rm unused code * magically fix parliament vote app tests * make checkbox labels clickable * fix conditionally revealing address option --------- Co-authored-by: zuzana <zuza.har@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private | ||
|
|
||
| def parse_given_link(given_url) | ||
| prefix = Regexp.escape(legal_link_prefix).gsub("/", "\\/") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
| reset_session | ||
|
|
||
| redirect_to root_path, notice: 'Odhlásenie bolo úspešné.' | ||
| if params[:callback].present? | ||
| redirect_to params[:callback] |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Riesi:
#471
Progress:
rc://sk/123214324_priezvisko_menoz udajov, co mi prisli