Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on disconnect() #261

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

uklotzde
Copy link
Member

Fixes #260.

@uklotzde uklotzde added this to the v0.13.1 milestone Jun 24, 2024
@uklotzde
Copy link
Member Author

Ideally, function_code() should not panic. This should have been caught when introducing FunctionCode. No one noticed 🤷

@uklotzde
Copy link
Member Author

TODO:

  • Yank v0.13.0
  • Release v0.13.1

The breaking change by extending FunctionCode then belongs to v0.13.

@uklotzde uklotzde requested a review from flosse June 24, 2024 22:33
@uklotzde uklotzde changed the title Panic on disconnect Fix panic on disconnect() Jun 24, 2024
@flosse flosse merged commit 8b04b2f into slowtec:main Jun 24, 2024
10 checks passed
@uklotzde uklotzde deleted the panic-on-disconnect branch June 24, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on unreachable code on disconnect
2 participants