Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update nodejs builder to use BYOB #1667

Merged
merged 57 commits into from
Feb 24, 2023
Merged

feat: Update nodejs builder to use BYOB #1667

merged 57 commits into from
Feb 24, 2023

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Feb 21, 2023 •
edited
Loading

Updates the nodejs builder to use BYOB.

Publishing to npmjs.com will be done on a separate PR.

TODO:

Signed-off-by: Ian Lewis ianlewis@google.com

@ianlewis
Remove call to getWorkflowRun
bae3f4b 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fixes
00995bf 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'main' into refactor-workflowref
21224ee 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update getWorkflowPath
d5d23ec 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fix lint issues
cc43812 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'main' into refactor-workflowref
3ac4ff4 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update validation
634b62d 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Remove unused imports
6ff13d8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fix error detection
e6f825d 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Cleanup of objects
54223de 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
remove unused import
8536b04 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
update dist
7f6abae 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update dist
64c2bf9 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
update setup-token e2e test
6368b32 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
use e2e-utils
d2ec790 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update .github/actions/verify-token/__tests__/validate.test.ts
7273366 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
validate workflow_ref starts with repo
44b284c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Basic workflow
d933701 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Add run-scripts
b3dd718 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Add directory input
b4e9f1f 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
run npm ci
9a70ca4 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Change to directory
db84359 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Add public-good-instance-root.json
915b5ab 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
workaround public-good-instance-root.json error
827f4cc 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fix for workaround
5000504 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Set shell
d161808 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Add secret inputs
49bf267 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Don't cache dependencies for now
ddfd254 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fix npm pack
bf17b87 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
make build.sh executable
ab21ff8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
fix subject
f5075ab 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Fix pack_json
bbfdde0 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
fix subjects
b56a7d1 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis mentioned this pull request Feb 21, 2023
Closed
@ianlewis
disable comments-indentation
a26a71a 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update todos
35a057c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
public-good-instance.json workaround
6bd40cc 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'public-good-instance-workaround' into npm-private-beta-…
83e29ef 
…workflow

Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'refactor-validation' into npm-private-beta-workflow
966135c 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Remove nodejs builder Go code
7ec4b8e 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Disable comments-indentation
ea13961 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'yamllint-comments-indentation' into npm-private-beta-wo…
538ef6d 
…rkflow

Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'main' into refactor-validation
1c1603a 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
update index.js.map
0c9f793 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Merge branch 'refactor-validation' into npm-private-beta-workflow
34728dc 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Don't run npm ci
b43d7a5 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis marked this pull request as ready for review February 22, 2023 06:51
laurentsimon
laurentsimon approved these changes Feb 22, 2023
View reviewed changes
internal/nodejs-action/action.yml Outdated Show resolved Hide resolved
@ianlewis
Merge branch 'main' into npm-private-beta-workflow
7b0fcb7 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
pin setup-node
c8064b3 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Revert reference to pr-workflow
8fba3a8 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Revert reference
ab833a4 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Add issue comment
a01bdcc 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Update todo comments
23f50ff 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis
Remove comment
6a2bde7 
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis enabled auto-merge (squash) February 24, 2023 05:18
@ianlewis ianlewis merged commit 478820e into slsa-framework:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianlewis @laurentsimon