Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test : Included tests for build.go #351

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Test : Included tests for build.go #351

merged 2 commits into from
Jun 22, 2022
+131 −0

Conversation

naveensrinivasan
Copy link
Collaborator

  • Included tests for build.go

Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan
Copy link
Collaborator Author

@laurentsimon 👀

ianlewis
ianlewis approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
asraa
asraa approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Wondering as well (non-blocking), for dry=false, can we look for the output binary to make sure we build something?

@naveensrinivasan
Copy link
Collaborator Author

Thanks! LGTM

Wondering as well (non-blocking), for dry=false, can we look for the output binary to make sure we build something?

As I mentioned in the previous comment I will do that in the follow up PR.

ianlewis
ianlewis reviewed Jun 21, 2022
View reviewed changes
internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
internal/builders/go/pkg/build_test.go Outdated Show resolved Hide resolved
@naveensrinivasan
Test : Included tests for build.go
c058fb0 
- Included tests for build.go

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan mentioned this pull request Jun 22, 2022
Open
@ianlewis ianlewis enabled auto-merge (squash) June 22, 2022 22:35
@ianlewis ianlewis merged commit 46d87be into slsa-framework:main Jun 22, 2022
@ianlewis ianlewis mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

@ianlewis ianlewis Awaiting requested review from ianlewis

@asraa asraa Awaiting requested review from asraa

@laurentsimon laurentsimon Awaiting requested review from laurentsimon laurentsimon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naveensrinivasan @ianlewis @asraa @laurentsimon