Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update READMEs to clarify that SLSA generators and builders must be referred by tag #957

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

diogoteles08
Copy link
Contributor

Previously, at some points across the different READMEs there were explanations on why it's necessary to refer the SLSA generators and builders using tags in the format @vX.Y.Z, but some of them were incomplete. This change adds a subtopic to the base README that contains all the explanation, and this subtopic is linked on other parts of READMEs that needs the explanation.

This issue was previously discussed with @laurentsimon

…ders

Previously, at some points accross the different READMEs there were
explanations on why it's necessary to refer the SLSA generators and
builders using tags in the format @vX.Y.Z, but some of them were
incomplete. This change adds a subtopic to the base README that
contains all the explanation, and this subtopic is linked on other
parts of READMEs that needs the explanation.

Signed-off-by: Diogo Teles Sant'Anna <diogoteles08@gmail.com>
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping!

README.md Outdated Show resolved Hide resolved
internal/builders/generic/README.md Outdated Show resolved Hide resolved
Signed-off-by: Diogo Teles Sant'Anna <diogoteles08@gmail.com>
README.md Outdated Show resolved Hide resolved
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis enabled auto-merge (squash) October 5, 2022 09:33
@ianlewis ianlewis merged commit 87722f4 into slsa-framework:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants