Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature][npm] Set the GitHub runner builder ID #494

Closed
laurentsimon opened this issue Feb 18, 2023 · 2 comments
Closed

[feature][npm] Set the GitHub runner builder ID #494

laurentsimon opened this issue Feb 18, 2023 · 2 comments
Labels
area:npm An issue with verification of npm packages type:feature New feature request
Milestone
Verification of n...

Comments

@laurentsimon
Copy link
Contributor

See https://github.com/gh-community/npm-provenance-private-beta-community/issues/9
@laurentsimon laurentsimon mentioned this issue Feb 18, 2023
Merged
@ianlewis ianlewis added type:feature New feature request area:npm An issue with verification of npm packages labels Feb 21, 2023
@laurentsimon laurentsimon changed the title [feature] Set the GitHub runner builder ID [feature][npm] Set the GitHub runner builder ID Feb 21, 2023
@laurentsimon
Copy link
Contributor Author

See discussion at slsa-framework/slsa#655

@laurentsimon
Copy link
Contributor Author

See slsa-framework/slsa#655 (comment), we have a name. I think there will be no version.

ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@joshuagl @ianlewis
Add additional guidance for users who don't pin by tag (slsa-framewor…
8c3ab33 
…k#494)

* Document the need to reference reusable workflows by tag

Signed-off-by: Joshua Lock <jlock@vmware.com>

* Add link to help users understand invalid builder version

Signed-off-by: Joshua Lock <jlock@vmware.com>

* Apply suggestions from code review

Co-authored-by: Ian Lewis <ianlewis@google.com>

Co-authored-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:npm An issue with verification of npm packages type:feature New feature request
Projects
None yet
Milestone
Verification of npm packages GA
Development

No branches or pull requests
2 participants
@ianlewis @laurentsimon