Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the diagrams easier to edit #363

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Conversation

MarkLodato
Copy link
Member

@MarkLodato MarkLodato commented Apr 13, 2022

As part of #360, clean up the Figma diagrams to make them easier to maintain and to use a consistent visual style.

Major changes:

  • Re-implement the "supply chain model" diagram in the same visual style as the other diagrams. (Previously it was made in Google Drawings and looked very different.)
  • Rename "bad dependency/package" to "risky dependency/package" as per Added revoked dependency threat #347. (@ThomasOwens FYI)

Minor visual changes:

  • Switch font to Inter, which is a Google Web Font, from Prodigy Sans. This allows editing without installing the font locally, in particular enabling editing on Linux and Chromebook.
  • Make the Package → Dependencies arrow dashed (liked the Dependencies box) to hint that a Dependency is itself a package.
  • Use the hexagonal Build shape consistently. (In some versions it was an oval.)
  • Adjust various alignments and spacings for consistency.
  • Use white background color consistency. (In some versions it was transparent, which renders poorly on GitHub with dark mode.)

Invisible cleanups:

  • Refactor the Figma file so that it's easier to maintain, and update the instructions to better explain how to use it.
  • Remove the fonts from our repo, since they are no longer needed.
  • Remove unused PNG file.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 921f477
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/626349ac2ab6aa0009c75b59
😎 Deploy Preview https://deploy-preview-363--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ThomasOwens
Copy link
Contributor

I very much appreciate this. Anything to keep reducing the barrier of entry for people contributing is fantastic, and Figma was a big one for me (never having used it or done much with any kind of image editing at all before).

@joshuagl
Copy link
Member

Looks like we completely lost the labels on docs/images/supply-chain-threats.svg, was that intentional?
There's a typo in docs/images/supply-chain-model.svg – depedencies --> dependencies

Use Google Web Font (Inter, Arimo) instead of custom alternatives
(Prodigy Sans, Arial) to allow easier edits. Visually it's very similar.

Rename "bad dependency" to "risky dependency" as per slsa-framework#347.

Update Figma file to match SVG (remove drop shadow, use non-oval shape
for Build, fix alignment).

Signed-off-by: Mark Lodato <lodato@google.com>
We don't need these anymore now that we use Google Web Fonts
exclusively.

Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
@MarkLodato
Copy link
Member Author

Looks like we completely lost the labels on docs/images/supply-chain-threats.svg, was that intentional?

Reverted. It was intentional, but I shouldn't mix that into this refactoring PR. The diagrams are back to how they were before, and I'll send out a separate to consider removing them.

There's a typo in docs/images/supply-chain-model.svg – depedencies --> dependencies

Thanks, fixed.

@MarkLodato MarkLodato requested review from joshuagl and removed request for mlieberman85 April 23, 2022 00:43
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling this!

@MarkLodato
Copy link
Member Author

Thanks for the review!

@MarkLodato MarkLodato merged commit 1b40835 into slsa-framework:main Apr 25, 2022
@MarkLodato MarkLodato deleted the fonts branch April 25, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants