-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the diagrams easier to edit #363
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I very much appreciate this. Anything to keep reducing the barrier of entry for people contributing is fantastic, and Figma was a big one for me (never having used it or done much with any kind of image editing at all before). |
d27a03e
to
ecb3b7c
Compare
Looks like we completely lost the labels on docs/images/supply-chain-threats.svg, was that intentional? |
Use Google Web Font (Inter, Arimo) instead of custom alternatives (Prodigy Sans, Arial) to allow easier edits. Visually it's very similar. Rename "bad dependency" to "risky dependency" as per slsa-framework#347. Update Figma file to match SVG (remove drop shadow, use non-oval shape for Build, fix alignment). Signed-off-by: Mark Lodato <lodato@google.com>
We don't need these anymore now that we use Google Web Fonts exclusively. Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
Reverted. It was intentional, but I shouldn't mix that into this refactoring PR. The diagrams are back to how they were before, and I'll send out a separate to consider removing them.
Thanks, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for tackling this!
Thanks for the review! |
As part of #360, clean up the Figma diagrams to make them easier to maintain and to use a consistent visual style.
Major changes:
Minor visual changes:
Invisible cleanups: