Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: Remove dashes from types in PR name lint #903

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

arewm
Copy link
Member

@arewm arewm commented Jul 7, 2023

resolves: #902

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for slsa canceled.

Name Link
🔨 Latest commit 5a6f8cb
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/64ac0860164d2500080f744d

resolves: slsa-framework#902

Signed-off-by: arewm <arewm@users.noreply.github.com>
CONTRIBUTING.md Show resolved Hide resolved
Signed-off-by: arewm <arewm@users.noreply.github.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: arewm <arewm@users.noreply.github.com>
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: arewm <arewm@users.noreply.github.com>
@arewm
Copy link
Member Author

arewm commented Jul 11, 2023

This PR is ready to merge.

@joshuagl joshuagl merged commit a9dcda4 into slsa-framework:main Jul 11, 2023
@arewm arewm deleted the pr-name-lint branch July 11, 2023 16:50
kpk47 pushed a commit to kpk47/slsa that referenced this pull request Jul 11, 2023
Dashes are not supported by the GitHub Action PR linter we use:
https://github.com/amannn/action-semantic-pull-request

resolves: slsa-framework#902

Signed-off-by: arewm <arewm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PR name lint check fails on types with dashes
5 participants