impl: use Netlify redirects instead of HTML #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Netlify's HTTP-level redirects instead of HTML-level `<meta refresh>` redirects. (Historical note: we originally used the latter because GitHub Pages did not support HTTP-level redirects.) Advantages: - Preserves URL fragments. Example: slsa.dev/levels#build-l3 no longer drops the `#build-l3`. - Supports directory redirection path components after the redirect. Example: slsa.dev/spec/v1/levels now works. - Supports temporary redirects (302). The problem with `<meta refresh>` is that they are always interpreted as permanent, which is a problem when we do a version bump (e.g. /levels -> /spec/v1.0/levels). - Cleans up our directory tree, which now only contains true content. Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Netlify's HTTP-level redirects instead of HTML-level
<meta refresh>redirects. (Historical note: we originally used thelatter because GitHub Pages did not support HTTP-level redirects.)
Advantages:
Example: slsa.dev/levels#build-l3 no longer drops the
#build-l3.Example: slsa.dev/spec/v1/levels now works.
<meta refresh>is that they are always interpreted as permanent, which is a problem
when we do a version bump (e.g. /levels -> /spec/v1.0/levels).
Signed-off-by: Mark Lodato lodato@google.com