content: create v1.1 directory #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec/v1.1/ directory is a copy of spec/v1.0/, while _data/nav/v1.1.yml is a copy of v1.0.yml with "1.0" replaced by "1.1". ```bash $ git ls-tree HEAD:docs/spec | grep 'v1.[01]$' 040000 tree 52008aa2d63ee43de55af463c016ea2b6771433a v1.0 040000 tree 52008aa2d63ee43de55af463c016ea2b6771433a v1.1 ``` Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't think our community guidelines make sense for draft branches. While this is technically "content", it is for a new release that is not yet approved so the full 3 reviewers + 72 hours doesn't make sense. |
joshuagl
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
LGTM
I don't think our community guidelines make sense for draft branches. While this is technically "content", it is for a new release that is not yet approved so the full 3 reviewers + 72 hours doesn't make sense.
Yes, agreed. They are only guidelines and have several edge cases. I think it's fine to have only two reviewers/approvers for this change, so long as edits to the spec meet the documented criteria.
Signed-off-by: Mark Lodato <lodato@google.com>
This was referenced Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec/v1.1/ directory is a copy of spec/v1.0/, while
_data/nav/v1.1.yml is a copy of v1.0.yml with "1.0" replaced by "1.1".
Signed-off-by: Mark Lodato lodato@google.com