Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup: avoid some NOTICE messages with PHP 5.6 #19

Merged
merged 12 commits into from
Nov 13, 2015
Merged

Code cleanup: avoid some NOTICE messages with PHP 5.6 #19

merged 12 commits into from
Nov 13, 2015

Conversation

albig
Copy link
Contributor

@albig albig commented Nov 11, 2015

Two issues are touched with this changeset:

  1. Depending on PHP and TYPO3 configuration the array()-handling in newspaper and SRU plugin may throw TYPO3 exceptions. This fix makes sure, foreach() is really called on an array().
  2. The SRU plugin now supports the draft of "SRU/ALTO-Anwendungsprofil 1.0". Minor changes were needed to build the SRU request URL in the specified way.

sebastian-meyer and others added 12 commits August 10, 2015 15:27
@sebastian-meyer
Add structures for newspapers to default
c921f91
@stweil
Fix typos found by codespell
114b75f 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Fix some warnings from PhpStorm
8e96194 
Remove an unneeded semicolon and add two semicolons
where they are required.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Fix syntax error found by PhpStorm
7bac98e 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Merge remote-tracking branch 'upstream/master'
e074855
check for existence of array before calling foreach()
6488b40
make sure given variables are arrays after unsetting
5acbb97
code cleanup - coding style
7082b1f
concatenate the SRU query string
9d04931
URL of METS file is now supported in search results
643c480
add recordSchema to SRU request URL
822e374
avoid javascript errors on pages without openlayers
c1bc324
albig pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #19 from albig/master
2734c00 
Code cleanup: avoid some NOTICE messages with PHP 5.6; 
SRU-plugin: fix request URL to meet current specification
@albig albig merged commit 2734c00 into slub:master Nov 13, 2015
chrizzor pushed a commit to effective-webwork/dfg-viewer that referenced this pull request Feb 15, 2024
@sebastian-meyer
Merge pull request slub#19 from opencultureconsulting/Full-text-featu…
1ee05a6 
…res-main

13.02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albig @sebastian-meyer @stweil