Change z-index to match the other buttons
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
csidirop
changed the title
z-index to match other the buttonsz-index to match the other buttons
|
Any questions regarding this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
z-indexespecially from the fullscreen button to match other the buttons.This will not make a difference most of the time. but in the rare case that an element overlays the buttons it will be noticeable. See here:
Pre:
-> after: 
I did some testing to ensure that
z-index: 1000;wasn't necessary, but as always if you can think of a reason why this is necessary, you can leave it as it is.