Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license comments in LESS file headers #233

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

gnuj
Copy link
Contributor

@gnuj gnuj commented Aug 23, 2023

To comply with the basic licence GPL-3.0 guidelines, this pull request removes the old licence information from the LESS file headers (see discussion). In addition, the obsolete and unnecessary //EOF statement at the end of the LESS and JS files is removed.

gnuj added 2 commits August 23, 2023 09:47
- Remove the license informations
- Remove the unnecessary //EOF statements
(...and also from one missing LESS file)
csidirop added a commit to csidirop/dfg-viewer that referenced this pull request Aug 23, 2023
  - Remove the license informations
  - Remove the unnecessary EOF statements

  See: slub#233

Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think that removing the "Author" lines would not be necessary. But as you are that author, it is your decision whether you want to keep those lines or not.

@gnuj
Copy link
Contributor Author

gnuj commented Aug 24, 2023

But as you are that author, it is your decision whether you want to keep those lines or not.

No, that's perfectly fine. As more and more people work on these files, it is the work of many and no longer just one. Thanks for the hint.

@sebastian-meyer sebastian-meyer merged commit bf67ec9 into slub:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants