Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cofiguration for tools to match changes in Kitodo Presentation #235

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

beatrycze-volk
Copy link
Contributor

@beatrycze-volk beatrycze-volk commented Aug 23, 2023

This PR is a fix for problem reported here: kitodo/kitodo-presentation#994

@stweil
Copy link
Contributor

stweil commented Aug 23, 2023

@csidirop, please test this fix.
@beatrycze-volk, maybe you want to fix the typo in the commit message.

@csidirop
Copy link
Contributor

I must be doing something wrong because I don't see any change. I merged #235 and #234 into master, flushed caches and did a full site reload.

Did I missed something?

Sitenote: I tried this in our Docker environment, so that I have a clean state for my tests.

@beatrycze-volk
Copy link
Contributor Author

I must be doing something wrong because I don't see any change. I merged #235 and #234 into master, flushed caches and did a full site reload.

Did I missed something?

No, you have done everything right. I have pinpointed the problem. There is still one more PR (slub/slub_digitalcollections#51) which needs to be merged.

It looks that this exact template is actually not contained in DFG-Viewer but instead it comes from SLUB Digital Collections:
template

Again thank you for your help :) I had this change already on my test system and because of that I thought that this part is already merged in slub_digitalcollections.

@csidirop
Copy link
Contributor

Okay thanks! I'll test it tomorrow.

@csidirop
Copy link
Contributor

Works fine again! Thanks :)

Copy link
Contributor

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Test at UB Mannheim was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants