-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test #25
Make test #25
Conversation
Thx for this implementation. I think we should dispense Or is it more convenient to use |
Ok, I thought we actually wanted this kind of encapsulation (because it also sets up venvs). I have no problem dropping in favour of several distinct commands (which could also include coverage tests or other linters). Let me know if I should rework this PR such that nox gets dropped.
ok, good to know. I'll rewrite the recipe. |
Note: I am not 100% sure this (
make test
implementation) is the right approach. IIUC I deactivated those tests which can only run outside a container. But I get connection failures for the other parts. I'll open an issue shortly about that problem specifically, as it is probably not related.