Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test #25

Merged
merged 10 commits into from
May 3, 2023
Merged

Make test #25

merged 10 commits into from
May 3, 2023

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented May 2, 2023

Note: I am not 100% sure this (make test implementation) is the right approach. IIUC I deactivated those tests which can only run outside a container. But I get connection failures for the other parts. I'll open an issue shortly about that problem specifically, as it is probably not related.

@markusweigelt
Copy link
Collaborator

markusweigelt commented May 3, 2023

Thx for this implementation. I think we should dispense nox from this repo and use only pytest and mypy. With pytest all test marked with integration are skipped (https://pypi.org/project/pytest-integration-mark/) so there is no need to remove test files separately.

Or is it more convenient to use nox locally in dev environment?

@bertsky
Copy link
Member Author

bertsky commented May 3, 2023

I think we should dispense nox from this repo and use only pytest and mypy.
Or is it more convenient to use nox locally in dev environment?

Ok, I thought we actually wanted this kind of encapsulation (because it also sets up venvs). I have no problem dropping in favour of several distinct commands (which could also include coverage tests or other linters).

Let me know if I should rework this PR such that nox gets dropped.

With pytest all test marked with integration are skipped (https://pypi.org/project/pytest-integration-mark/) so there is no need to remove test files separately.

ok, good to know. I'll rewrite the recipe.

@SvenMarcus SvenMarcus merged commit 75e07a2 into slub:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants