Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install monitor into separate venv #32

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Install monitor into separate venv #32

merged 2 commits into from
Aug 10, 2023

Conversation

SvenMarcus
Copy link
Collaborator

Due to conflicts with browse-ocrd resulting from our upgraded pydantic version, the OCRD Monitor needs to be installed into a separate virtual environment.

I added PDM to the Dockerfile and set up a new command to run the monitor with PDM.

markusweigelt
markusweigelt approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Sometimes we get an connection error while testing.

Created an issue for that. #33

@markusweigelt markusweigelt merged commit 0b94b2b into slub:main Aug 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusweigelt markusweigelt markusweigelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvenMarcus @markusweigelt