[Feature][ref #18] ClojureScript #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatibility issues with clojure/tools.reader
…rst working cljs build via lein-cljsbuild.
…ch.data and bach.track namespaces 🎉
…to json when compiling for cljs
…arse defparser in bach.ast for idiomatic compatibility with cljs
…ge info to README
…js integration and named exports
…ment to bach-cljs package.json
…t for bach-cljs
…ed up project.clj
…mpatible (breaking change, since default export is now an object instead of a function :warning)
…round integration with JS module systems
…and CommonJS imports
… in bach.ast using insta/defparser)
…as only used in cljsbuild. Still need to rethink bach.cli around ClojureScript.
…o-to-vector (capitalized)
…ClojureScript (works in ClojureScript, regression in Clojure due to require macros)
…n Clojure and ClojureScript
…eScript refactor
…ClojureScript refactor
…to package.json
…for greater compatibility with NPM publish
…ol for easier platform-agnostic installation (e.g. not NPM).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
bach-cljspackage to NPM (v1.0.3due to missingtarget/jsfolder during publish, changed todist)shadow-cljsto build ClojureScript libraryresources/grammar.bnfusinginsta/defparserinbach.astbach.track/get-pulse-beatto use more direct and idiomaticbach.data/gcd(generic greatest common denominator method)2.1.0Caveats
bach.track/composeis exported since all "internal" methods work with Clojure maps instead of JSON. Also ratios.commonjsandes6imports are supported (:esmwill come later)Future
:esmbundlescompiletocomposeinbach.cli(generally give theclisome love, particularly around ClojureScript)Tickets