LoRA manual MLIR model #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds manually written MLIR LoRA snippet and further parametrizes benchmark model creation.
The MLIR snippet creates weights as constants to allow for compile-time packing. Function arguments and operations are kept in line with subgraph created by OV MLIR outlining.
Benchmark model builders are parametrized to allow control over weights matrix and LoRA dimensions.
The new model's performance is measured as 'manual MLIR' which evaluates pure MLIR performance with more optimal input IR compared to the current OV outlining.