Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unicode in SQL Server BULK INSERT statements. #152

Merged
merged 3 commits into from
Apr 10, 2019

Conversation

devilgate
Copy link
Member

As discussed in #79. Note that I have just added DATAFILETYPE = 'widechar' clauses to the WITH blocks of all the BULK INSERT statements.

Turns out we use them a lot. There are SQL scripts, Java classes and JavaScript files. Also at least one C++ file. I don't even know what that's doing there, but it didn't need to change, luckily.

Note that I haven't tested this.

@devilgate devilgate requested a review from peterhambly April 4, 2019 11:59
@peterhambly
Copy link
Contributor

Works with minor changes. Note does not fix #79; required bulk loader format (.fmt) files to be changed from SQL <COLUMN SOURCE="1" NAME="statefp" xsi:type="SQLVARYCHAR" /> to <COLUMN SOURCE="1" NAME="statefp" xsi:type="SQLNVARYCHAR" /> for those columns that are declared as NVARCHAR.

@peterhambly peterhambly merged commit 87784c7 into master Apr 10, 2019
@peterhambly peterhambly deleted the bug/#79_SQL_Server_bulk_insert_needs_unicode branch April 10, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants