Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ToolsContent overflow issue #179

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

alashchev17
Copy link
Contributor

Fix: ToolsContent overflow issue

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

How to Test

  • Step 1: Ask in the chat to call tree
  • Step 2: Expand tool content, then check scroll
  • Step 3: Click on "Click for more" to expand collapsible, scroll should increase correctly

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

@alashchev17 alashchev17 self-assigned this Oct 31, 2024
@MarcMcIntosh
Copy link
Collaborator

Would i work with the custom <ScrollArea> component?

@@ -118,7 +118,13 @@ export const ToolContent: React.FC<{

return (
<Container>
<Collapsible.Root open={open} onOpenChange={setOpen}>
<Collapsible.Root
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can thie be wrapped in ScrollArea that way it's consistent with the other scroll bars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants