Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting data for statistic from endpoint #4

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Getting data for statistic from endpoint #4

merged 7 commits into from
Feb 28, 2024

Conversation

ViktoriiaNakoryk
Copy link
Contributor

added events and methods for getting data from endpoint

@ViktoriiaNakoryk ViktoriiaNakoryk marked this pull request as draft February 24, 2024 20:51
@ViktoriiaNakoryk ViktoriiaNakoryk marked this pull request as ready for review February 26, 2024 14:04
Copy link
Collaborator

@MarcMcIntosh MarcMcIntosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one small suggestion and I also need to run it.
Which lsp branch should i use for running it?

src/services/refact.ts Outdated Show resolved Hide resolved
@MarcMcIntosh
Copy link
Collaborator

MarcMcIntosh commented Feb 26, 2024

I got a 500 response code when running this because the database was not ready,
Screenshot 2024-02-26 at 16 01 18

but the spinner keeps spinning, maybe we should notify the user somehow?

Probably won't be an issue when running the lsp locally, but for self hosted it's a possibility

src/hooks/useEventBusForStatistic.ts Outdated Show resolved Hide resolved
@MarcMcIntosh MarcMcIntosh changed the base branch from main to vecdb February 28, 2024 11:19
@MarcMcIntosh MarcMcIntosh changed the base branch from vecdb to main February 28, 2024 11:19
@MarcMcIntosh MarcMcIntosh merged commit 18ada88 into main Feb 28, 2024
2 checks passed
@MarcMcIntosh MarcMcIntosh deleted the statistic branch February 28, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants