Error notification fix (#83)

* fix error check * hide eta for finished runs * eta only for working * stash fixed --------- Co-authored-by: oxyplay <max@oxyplay.com>
smallcloudai · Aug 31, 2023 · faff63c · faff63c
1 parent 79e152d
commit faff63c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/self_hosting_machinery/webgui/static/tab-finetune.js b/self_hosting_machinery/webgui/static/tab-finetune.js
@@ -121,7 +121,7 @@ function render_runs() {
         } else {
             run_status.innerHTML = `<span class="badge rounded-pill ${status_color}">${element.status}</span>`;
         }
-        if (element.eta_minutes) {
+        if (element.status === 'working' && element.eta_minutes ) {
             run_minutes.innerHTML = element.eta_minutes;
         }
         run_steps.innerHTML = element.worked_steps;

diff --git a/self_hosting_machinery/webgui/static/tab-model-hosting.js b/self_hosting_machinery/webgui/static/tab-model-hosting.js
@@ -86,13 +86,13 @@ function get_models()
         enable_chat_gpt_switch.checked = models_data['openai_api_enable'];
         enable_chat_gpt_switch.addEventListener('change', save_model_assigned);
         const more_gpus_notification = document.querySelector('.model-hosting-error');
-        if(models_data && models_data.length > 0 && models_data.more_models_than_gpus) {
+        if(data.hasOwnProperty('more_models_than_gpus') && data.more_models_than_gpus) {
             more_gpus_notification.classList.remove('d-none');
         } else {
             more_gpus_notification.classList.add('d-none');
         }
         const required_memory_exceed_available = document.querySelector('.model-memory-error');
-        if(models_data && models_data.length > 0 && models_data.required_memory_exceed_available) {
+        if(data.hasOwnProperty('required_memory_exceed_available') && data.required_memory_exceed_available) {
             required_memory_exceed_available.classList.remove('d-none');
         } else {
             required_memory_exceed_available.classList.add('d-none');