Headless operation for docker #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitya52
requested changes
Apr 24, 2024
Comment on lines
76
to
78
| for _ in range(10): | ||
| inference_model.infer(dummy_call, DummyUploadProxy, {}) | ||
| if compile: |
There was a problem hiding this comment.
do we really need 10 times inference of test batch?
| continue | ||
| text = open(fn).read() | ||
|
|
||
| model_assigner.models_to_watchdog_configs() |
There was a problem hiding this comment.
this is needed if we remove something from models list (deprecated or something)
Comment on lines
440
to
455
| def first_run(): | ||
| if HEADLESS: | ||
| return | ||
| subprocess.check_call(FIRST_RUN_CMDLINE) | ||
|
|
||
|
|
||
| def main_loop(): | ||
| # Generate a random SMALLCLOUD_API_KEY, it will be inherited by subprocesses, | ||
| # this allows inference_worker to authorize on the local web server (both use | ||
| # this variable), and work safely even if we expose http port to the world. | ||
| os.environ["SMALLCLOUD_API_KEY"] = str(uuid.uuid4()) | ||
| if not HEADLESS: | ||
| # Generate a random SMALLCLOUD_API_KEY, it will be inherited by subprocesses, | ||
| # this allows inference_worker to authorize on the local web server (both use | ||
| # this variable), and work safely even if we expose http port to the world. | ||
| os.environ["SMALLCLOUD_API_KEY"] = str(uuid.uuid4()) | ||
| else: | ||
| assert "SMALLCLOUD_API_KEY" in os.environ | ||
|
|
||
| first_run() |
There was a problem hiding this comment.
it will be better to move first_run call under not HEADLESS branch
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| from refact_utils.scripts import env | |||
|
|
|||
| HEADLESS = ("--headless" in sys.argv) # for ui-less docker: skip all standard cfg-s (web ui, enum gpus, etc), skip first_run script | |||
mitya52
requested changes
May 8, 2024
mitya52
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.