-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
allow primitive type signatures on fields
The grammar for generic signatures in the JVMS is pretty clear that a signature for a field is a reference type signature. However, there are class files in the wild that contain a primitive type signature for a field. This commit makes that acceptable in Jandex, even though it technically isn't valid bytecode.
- Loading branch information
Showing
2 changed files
with
73 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
core/src/test/java/org/jboss/jandex/test/FieldWithPrimitiveTypeSignatureTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
package org.jboss.jandex.test; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
|
||
import java.io.IOException; | ||
|
||
import org.jboss.jandex.ClassInfo; | ||
import org.jboss.jandex.FieldInfo; | ||
import org.jboss.jandex.Index; | ||
import org.jboss.jandex.PrimitiveType; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import net.bytebuddy.ByteBuddy; | ||
import net.bytebuddy.asm.AsmVisitorWrapper; | ||
import net.bytebuddy.description.field.FieldDescription; | ||
import net.bytebuddy.description.field.FieldList; | ||
import net.bytebuddy.description.method.MethodList; | ||
import net.bytebuddy.description.type.TypeDescription; | ||
import net.bytebuddy.implementation.Implementation; | ||
import net.bytebuddy.jar.asm.ClassVisitor; | ||
import net.bytebuddy.jar.asm.FieldVisitor; | ||
import net.bytebuddy.pool.TypePool; | ||
import net.bytebuddy.utility.OpenedClassReader; | ||
|
||
public class FieldWithPrimitiveTypeSignatureTest { | ||
private static final String TEST_CLASS = "org.jboss.jandex.test.TestClass"; | ||
|
||
// the Oracle JDBC driver in version 23.3.0.23.09 contains a class with a field | ||
// whose generic signature encodes a primitive type, which is invalid per JVMS | ||
|
||
@Test | ||
public void test() throws IOException { | ||
byte[] bytecode = new ByteBuddy() | ||
.subclass(Object.class) | ||
.name(TEST_CLASS) | ||
.defineField("foo", boolean.class) | ||
.visit(new AsmVisitorWrapper.AbstractBase() { | ||
@Override | ||
public ClassVisitor wrap(TypeDescription instrumentedType, ClassVisitor classVisitor, | ||
Implementation.Context implementationContext, TypePool typePool, | ||
FieldList<FieldDescription.InDefinedShape> fields, MethodList<?> methods, | ||
int writerFlags, int readerFlags) { | ||
return new ClassVisitor(OpenedClassReader.ASM_API, classVisitor) { | ||
@Override | ||
public FieldVisitor visitField(int access, String name, String descriptor, String signature, | ||
Object value) { | ||
if ("foo".equals(name)) { | ||
signature = "Z"; // boolean | ||
} | ||
return super.visitField(access, name, descriptor, signature, value); | ||
} | ||
}; | ||
} | ||
}) | ||
.make() | ||
.getBytes(); | ||
ClassInfo clazz = Index.singleClass(bytecode); | ||
|
||
assertEquals(1, clazz.fields().size()); | ||
FieldInfo field = clazz.field("foo"); | ||
assertNotNull(field); | ||
assertEquals(PrimitiveType.BOOLEAN, field.type()); | ||
} | ||
} |