Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing the notion of "data version" #181

Closed
Ladicek opened this issue Apr 8, 2022 · 1 comment · Fixed by #210
Closed

consider removing the notion of "data version" #181

Ladicek opened this issue Apr 8, 2022 · 1 comment · Fixed by #210
Labels
breaking-change Changes that break API backwards compatibility
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Apr 8, 2022

IndexReader and its related classes expose 2 notions of version: index version (version of the persistent format) and data version (version of information stored in the persistent format). The original idea was (probably) that these 2 would increment in parallel when new data were added to the persistent format, but the data version would stay intact if only the persistent format changed and no new information is added (i.e., persistent format refactoring).

I don't think this has ever been used. More importantly, IndexReaderV2 still reports data version as 4, even though the index version was incremented multiple times.

@Ladicek Ladicek added the breaking-change Changes that break API backwards compatibility label Apr 8, 2022
@Ladicek Ladicek added this to the 3.0.0 milestone Apr 8, 2022
@Ladicek Ladicek linked a pull request May 30, 2022 that will close this issue
@Ladicek
Copy link
Contributor Author

Ladicek commented May 30, 2022

Done in #210.

@Ladicek Ladicek closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that break API backwards compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant