remove the notion of data version #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data version number wasn't kept up to date, most likely because noone even knows there was a difference between index version and data version. This commit removes the notion of data version and intentionally conflates the index format version and data version. It's not like Jandex has ever changed its persistent format without also changing the data contract...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data version number wasn't kept up to date, most likely because
noone even knows there was a difference between index version and
data version. This commit removes the notion of data version and
intentionally conflates the index format version and data version.
It's not like Jandex has ever changed its persistent format without
also changing the data contract...
Resolves #181