Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Improvements and JDK update #155

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

stuartwdouglas
Copy link
Contributor

  • Update to JDK 1.8
  • Add convenience methods to IndexView
    I don't really know if this should go into a minor because of the JDK update, but this will get rid of a heap of boilerplate in Quarkus where we are wrapping String's in DotName for lookups.

@Ladicek
Copy link
Contributor

Ladicek commented Oct 8, 2021

The smallrye branch is already updated to Java 1.8, and this will be released as 3.0. It certainly won't go into any 2.x release.

Adding the convenience methods certainly makes sense, but I think it might be even better if we accepted Class objects? From what I saw in Quarkus, that is the most common case.

@stuartwdouglas
Copy link
Contributor Author

I have added Class versions as well

@Ladicek Ladicek added this to the 3.0.0 milestone Oct 11, 2021
@Ladicek
Copy link
Contributor

Ladicek commented Oct 11, 2021

OK I realized that with default methods, this actually requires Java 8 and hence can't go into 2.x. This has to go into 3.0.

@Ladicek Ladicek changed the base branch from master to smallrye October 11, 2021 14:39
@Ladicek
Copy link
Contributor

Ladicek commented Oct 11, 2021

I rebased on the smallrye branch (which is Jandex 3.0 work in progress) and force-pushed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants