Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Support ClassInfo signature at any position #162

Merged
merged 2 commits into from
Jan 5, 2022
Merged

[2.4] Support ClassInfo signature at any position #162

merged 2 commits into from
Jan 5, 2022

Conversation

MikeEdgar
Copy link
Member

Fixes #160

@MikeEdgar MikeEdgar mentioned this pull request Jan 5, 2022
Merged
@MikeEdgar
Copy link
Member Author

CI will fail without wildfly:typeannotation-test release including wildfly/typeannotation-test#3

@Ladicek
Copy link
Contributor

Ladicek commented Jan 5, 2022

Looks fine. Do you want to submit a PR against the smallrye branch, or should I?

@Ladicek Ladicek modified the milestones: 2.4.1.Final, 2.4.2.Final Jan 5, 2022
@Ladicek Ladicek changed the title Support ClassInfo signature at any position [2.4] Support ClassInfo signature at any position Jan 5, 2022
@Ladicek
Copy link
Contributor

Ladicek commented Jan 5, 2022

I submitted a PR to the smallrye branch: #163

@Ladicek Ladicek merged commit d3960e0 into smallrye:master Jan 5, 2022
@Ladicek
Copy link
Contributor

Ladicek commented Jan 5, 2022

I guess you'd like to have 2.4.2 released with this fix soon? :-)

@MikeEdgar MikeEdgar deleted the 160_class_sig_midlist branch January 5, 2022 12:54
@MikeEdgar
Copy link
Member Author

Thanks for handling this and doing the smallrye PR. Whenever you get a chance for a release is OK.

@Ladicek
Copy link
Contributor

Ladicek commented Jan 5, 2022

Thank you for submitting the PR! I'm looking into #161 and if there's a realistic chance I'm able to fix it today or tomorrow, I'd rather include it. If not, I'll release 2.4.2 just with this fix -- today or tomorrow at latest. Please shout if that doesn't work for you.

@Ladicek
Copy link
Contributor

Ladicek commented Jan 6, 2022

Jandex 2.4.2.Final is on its way to Central. Jandex Maven plugin will follow tomorrow.

@Ladicek
Copy link
Contributor

Ladicek commented Jan 7, 2022

And Jandex Maven plugin 1.2.2 is out and on its way to Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.2.Final
Development

Successfully merging this pull request may close these issues.

Class signature parsing skipped for records
3 participants
@MikeEdgar @Ladicek @n1hility