Fix wrong type parameter sharing in generic signature parser #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic signature parser used to forget previously encountered element-level type parameters when parsing a signature of a new element, and previously encountered class-level type parameters when parsing a signature of a new class. This leaves a hole: previously encountered element-level type parameters could be used when parsing a signature of a new class. When parsing a signature of a new class, previously encountered element-level type parameters must also be forgotten, to prevent wrong sharing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic signature parser used to forget previously encountered
element-level type parameters when parsing a signature of a new
element, and previously encountered class-level type parameters when
parsing a signature of a new class. This leaves a hole: previously
encountered element-level type parameters could be used when
parsing a signature of a new class. When parsing a signature of
a new class, previously encountered element-level type parameters
must also be forgotten, to prevent wrong sharing.
Fixes #98