improve type annotations handling #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add a few more test cases, because type annotations are WEIRD. But after many failed attempts, I feel like I finally found a decent solution, yay! |
Ladicek
force-pushed
the
type-annotations-fixes
branch
from
2b81a28 to
bcde530
Compare
|
Tests added, this should be good to go now. Assuming tests pass -- I've seen the Calcite regression test failing and will likely have to investigate that. |
Ladicek
force-pushed
the
type-annotations-fixes
branch
from
bcde530 to
82425cb
Compare
|
Fixed a stupid NPE, the Calcite regression test should pass now. |
|
The Calcite regression tests still fails, but I can no longer reproduce the failure locally. When I download the |
|
Configuring the Gradle action to not cache Jandex artifacts in the Calcite regression test helped :-) |
Ladicek
force-pushed
the
type-annotations-fixes
branch
from
c286063 to
7c0bbc5
Compare
This commit includes several improvements: - `Type.toString()` no longer shows type annotations before a package name, because package names can't be annotated; - type annotations on types that are local classes are supported properly; - type annotations on outermost annotable types are supported properly.
Ladicek
force-pushed
the
type-annotations-fixes
branch
from
7c0bbc5 to
4a3b695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several things:
Type.toString()no longer shows type annotations before a package name,because package names can't be annotated;
Fixes #161.