Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message for Assert.assertTrue and Assert.assertFalse #21

Closed
torinthiel opened this issue Apr 12, 2020 · 0 comments · Fixed by #22
Closed

Incorrect error message for Assert.assertTrue and Assert.assertFalse #21

torinthiel opened this issue Apr 12, 2020 · 0 comments · Fixed by #22
Milestone

Comments

@torinthiel
Copy link

assert expr : Messages.log.expectedBoolean(expr);
and
assert !expr : Messages.log.expectedBoolean(expr);
reference the error message with the current value of the argument. However the message in this case reads 'Internal error: Assertion failure: Expected boolean value to be %s', referencing the expected value. Thus a test of Assert.assertTrue(false) fails with confusing message 'Internal error: Assertion failure: Expected boolean value to be false'.

dmlloyd added a commit to dmlloyd/smallrye-common that referenced this issue Apr 13, 2020
@kenfinnigan kenfinnigan added this to the 1.0.1 milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants