Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reference support submodule #140

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Introduce reference support submodule #140

merged 2 commits into from
Mar 25, 2022

Conversation

dmlloyd
Copy link
Collaborator

@dmlloyd dmlloyd commented Mar 18, 2022

This would replace usages of wildfly-common's ref subpackage.

radcortez
radcortez previously approved these changes Mar 21, 2022
@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

Updated to use signed commits.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

I don't understand the Windows failure. It's happening during BOM generation.

@dmlloyd dmlloyd requested a review from a team as a code owner March 21, 2022 14:22
@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

I added a commit to print some debug logs to see what's going on.

@radcortez
Copy link
Member

Strange, the previous build seems ok. I don't see a reason for that error either.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

Here's the root exception:

Caused by: java.lang.NoSuchMethodException: org.apache.maven.session.scope.internal.SessionScope.memento()
    at java.lang.Class.getDeclaredMethod (Class.java:2475)
    at io.sundr.maven.Reflections.getMemento (Reflections.java:44)
    at io.sundr.maven.ReactorContextFactory.create_3_3_x (ReactorContextFactory.java:72)
    at io.sundr.maven.ReactorContextFactory.create (ReactorContextFactory.java:46)
    at io.sundr.maven.GenerateBomMojo.build (GenerateBomMojo.java:397)
    at io.sundr.maven.GenerateBomMojo.execute (GenerateBomMojo.java:151)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:301)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:211)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:165)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:157)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:121)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:127)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

The memento method and its corresponding class were added in Maven 3.3.0, according to the JavaDoc.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

I can only speculate that the Maven version on the Windows node was recently updated, and that sundr isn't compatible. I'm trying to verify that now.

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

Confirmed. Works with 3.8.2, fails with 3.8.5.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

sundrio/sundrio#309

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

I've dropped the debug logging commit so this is mergeable now, at least once the sundr problem is sorted out.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Mar 21, 2022

Here's an idea for a workaround using Maven wrappers.

@radcortez
Copy link
Member

Here's an idea for a workaround using Maven wrappers.

Updated the workflows to use the maven wrapper, so the build passes now.

Feel free to merge the PR :)

@dmlloyd dmlloyd merged commit b7f90c0 into smallrye:main Mar 25, 2022
@dmlloyd dmlloyd deleted the ref branch March 25, 2022 12:37
@radcortez radcortez added this to the 1.11.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants