Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move baseline to Java 17 #349

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Move baseline to Java 17 #349

merged 1 commit into from
Oct 25, 2024

Conversation

dmlloyd
Copy link
Collaborator

@dmlloyd dmlloyd commented Sep 27, 2024

Fixes #348, and some other minor issues as well

@dmlloyd dmlloyd requested a review from a team as a code owner September 27, 2024 15:47
radcortez
radcortez previously approved these changes Sep 27, 2024
@radcortez
Copy link
Member

Please wait until next week for our SR meeting so we can also discuss this there.

Fixes smallrye#348, and some other minor issues as well
@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Oct 9, 2024

Any update?

@radcortez
Copy link
Member

We can move once we make final releases to support MP 7.0. Not all implementations are required, but it probably wouldn't hurt to have all components to make a final release with 11 before moving to 17.

@radcortez
Copy link
Member

Maybe we should do a Parent update to 17 first, release, and then here?

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Oct 14, 2024

The parent doesn't really need to change until there are no consumers left which rely on 11 AFAICT. I don't think it makes sense to block on it at any rate.

@dmlloyd dmlloyd mentioned this pull request Oct 16, 2024
@dmlloyd dmlloyd linked an issue Oct 23, 2024 that may be closed by this pull request
@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Oct 23, 2024

Now that 2.8.0 was released, what do we think about moving this forward?

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Oct 25, 2024

Per conversations, I'm going ahead with this. If there is a specific problem, please let me know (I'm on Zulip).

@dmlloyd dmlloyd merged commit f12dee8 into smallrye:main Oct 25, 2024
4 checks passed
@dmlloyd dmlloyd deleted the java17 branch October 25, 2024 16:38
@github-actions github-actions bot added this to the 2.9.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources submodule has wrong module identifier Move to Java 17 as a baseline requirement
2 participants