Introduce JarEntries, tests and io.smallrye.common.io.jar package #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Jul 15, 2020
gastaldi
force-pushed
the
jar_entries
branch
2 times, most recently
from
a47b46d to
40dab94
Compare
gastaldi
changed the title
|
There you go, now it should work with JDK 9+ |
Ladicek
reviewed
Jul 16, 2020
dmlloyd
reviewed
Jul 16, 2020
|
Also might need to update the CI config... let me look into that. |
gastaldi
force-pushed
the
jar_entries
branch
2 times, most recently
from
f2659cf to
8ef8d4c
Compare
Ladicek
reviewed
Jul 16, 2020
Ladicek
reviewed
Jul 16, 2020
|
See #38. |
|
A rebase is needed now (sorry about that!) |
dmlloyd
approved these changes
Jul 16, 2020
|
It looks like the tests only ran with java8 and default (java 11). Looking into it... |
|
The tests run when I locally check out this PR, so there must have been a problem with #38. I'll look into that separately. AFAICT this PR can be merged (just pending @kenfinnigan). |
|
No need to pend on me, I was just sticking my nose in yesterday |
|
OK 👍 |
|
Yay! Thank you! Can I haz a release soon? |
|
Yes. We can push one now. |
|
Well we need to fix the tests first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JarEntry.getRealName() was introduced in JDK 10 only.
Necessary for quarkusio/quarkus#10756