Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter cache directory to .gitignore #44

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

dmlloyd
Copy link
Collaborator

@dmlloyd dmlloyd commented Jul 20, 2020

No description provided.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Make sure to also update the formatter plugin to 2.12.1, so this directory will only be created if it did not actually write any files for update within the cache

See https://github.com/revelc/formatter-maven-plugin/blob/formatter-maven-plugin-2.12.1/CHANGELOG.md#ver-2121

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Jul 20, 2020

I think that part would have to be done on smallrye-parent. I'll check into it.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Jul 20, 2020

Yep the parent is already updated, so that will come through when dependabot comes with the update.

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented Jul 20, 2020

I'm merging manually, because the build will never run due to the change being made to an ignored file.

@dmlloyd dmlloyd merged commit 5783619 into smallrye:master Jul 20, 2020
@dmlloyd dmlloyd deleted the gitignore branch July 20, 2020 14:13
@radcortez radcortez added this to the 1.2.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants